Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase nginx timeout to 300s #384

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Increase nginx timeout to 300s #384

merged 6 commits into from
Apr 22, 2024

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Apr 18, 2024 •
edited
Loading

Applicable spec:
N/A

Overview

Increase nginx timeout to 300s

Rationale

Some users are experiencing timeouts when handling large chunks of data

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

@arturo-seijas arturo-seijas requested a review from a team as a code owner April 18, 2024 07:36
merkata
merkata previously approved these changes Apr 18, 2024
View reviewed changes
Thanhphan1147
Thanhphan1147 previously approved these changes Apr 18, 2024
View reviewed changes
Thanhphan1147
Thanhphan1147 previously approved these changes Apr 18, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Test coverage for fc4ef74

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/charm.py                 323      9     82      7    96%   605, 646-647, 735->751, 737->746, 746->751, 759-760, 799, 832->exit, 870-876
src/database_observer.py      33      0      4      0   100%
src/s3_observer.py            18      0      0      0   100%
src/saml_observer.py          15      0      0      0   100%
src/smtp_observer.py          16      0      0      0   100%
src/state.py                  74      0     10      0   100%
----------------------------------------------------------------------
TOTAL                        479      9     96      7    97%

Static code analysis report

Run started:2024-04-22 07:47:07.517870

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2885
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 9fed103 into main Apr 22, 2024
23 of 25 checks passed
@arturo-seijas arturo-seijas deleted the increase-timeout branch April 22, 2024 14:47
@arturo-seijas arturo-seijas restored the increase-timeout branch April 24, 2024 07:17
@arturo-seijas arturo-seijas deleted the increase-timeout branch April 24, 2024 07:18
@arturo-seijas arturo-seijas restored the increase-timeout branch April 24, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbartz cbartz cbartz approved these changes

@javierdelapuente javierdelapuente javierdelapuente approved these changes

@merkata merkata Awaiting requested review from merkata

@Thanhphan1147 Thanhphan1147 Awaiting requested review from Thanhphan1147

Assignees
No one assigned
Labels
Libraries: OK trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arturo-seijas @javierdelapuente @merkata @cbartz @Thanhphan1147